Suppress caching of Secrets and ConfigMaps #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we still need to watch secrets? |
Good spot 🕵️ Probably not, but let me verify that. |
As explained in kubernetes-sigs/controller-runtime#1249, the controller-runtime client will tend to use LIST and WATCH to cache resources requested by the controller. This has two downsides: - the mechanism may require broad RBAC access (Secret and ConfigMap in every namespace) even if the actual secrets and configmaps referenced are few, or restricted to few namespaces; - the cache uses a lot of memory that it doesn't really need to This change fixes those problems, with the trade-off that all Secret and ConfigMap requests use a round-trip to the Kubernetes API server. This follows fluxcd/source-controller#989. There, a feature flag can be used to restore caching for Secrets and ConfigMaps; I have not included the feature flag, since this controller is much younger and doesn't have an established behaviour. Signed-off-by: Michael Bridgen <[email protected]>
One consequence of disabling caching for Secret resources, as in the previous commit, is that `watch` permission for those is no longer required. Signed-off-by: Michael Bridgen <[email protected]>
squaremo
force-pushed
the
no-cache-secrets-configmaps
branch
from
0989d3e
to
e2ff348
Compare
The controller doesn't watch them (in |
bigkevmcd
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23.
As explained in
kubernetes-sigs/controller-runtime#1249, the controller-runtime client will tend to use LIST and WATCH to cache resources requested by the controller. This has two downsides:
This change fixes those problems, with the trade-off that all Secret and ConfigMap requests use a round-trip to the Kubernetes API server.
This follows
fluxcd/source-controller#989. There, a feature flag can be used to restore caching for Secrets and ConfigMaps; I have not included the feature flag, since this controller is much younger and doesn't have an established behaviour.