Improve the ImagePolicy tests. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the e2e-tests to ensure that the ImagePolicy is saved before attempting to patch the Status (which we need to do because the image-policy isn't running.)
foot
reviewed
Dec 13, 2023
| @@ -46,7 +46,7 @@ help: ## Display this help. | |||
| ##@ Development | |||
|
|
|||
| .PHONY: manifests | |||
| manifests: api-docs controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | |||
There was a problem hiding this comment.
This worked for me after rm bin/gen-crd-api-reference-docs from the gs path.
But not sure why/what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This improves the e2e-tests to ensure that the ImagePolicy is saved before attempting to patch the Status (which we need to do because the image-policy isn't running.)
Release Notes