Merge pull request #157 from weaveworks/fix-event-type

Fix the event type for error cases.
weaveworks · Dec 14, 2023 · 5be78bb · 5be78bb
2 parents 317333c + c446768
commit 5be78bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/gitopsset_controller.go b/controllers/gitopsset_controller.go
@@ -76,9 +76,9 @@ func (r *GitOpsSetReconciler) event(obj *templatesv1.GitOpsSet, severity, msg st
 		reason = severity
 	}
 
-	eventType := "Normal"
+	eventType := corev1.EventTypeNormal
 	if severity == eventv1.EventSeverityError {
-		eventType = "Error"
+		eventType = corev1.EventTypeWarning
 	}
 
 	r.EventRecorder.Event(obj, eventType, reason, msg)

diff --git a/tests/e2e/gitopsset_controller_test.go b/tests/e2e/gitopsset_controller_test.go
@@ -1028,7 +1028,7 @@ func TestEventsWithFailingReconciling(t *testing.T) {
 		// reconciliation should fail because there is an existing resource.
 		want := []*test.EventData{
 			{
-				EventType: "Error",
+				EventType: corev1.EventTypeWarning,
 				Reason:    "ReconciliationFailed",
 			},
 		}