Add flag to log requests at info level

[colin-stuart]

Adds an optional flag to log requests at the info level, still defaulting to logging requests at the debug level.

[cinaglia]

Wanted to leave some preliminary feedback until maintainers chime in.

[cinaglia]

My hunch is that it would preferable to place this under LogSourceIPsRegex alongside the the log-related flags.

Also, we should:

• Add a yaml tag so it can be configured via file
• Update (cfg *Config).RegisterFlags to accept a server.log-requests-at-info-level flag.

[bboreham]

Thanks for the PR.

It’s now calling logWithRequest about six times; can you factor that out?

[colin-stuart]

Thanks for the the review @bboreham, let me know what you think about the refactor. Another option would be to add another global convenience function that takes a level string and a calls the appropriate Debugf()/Infof()/etc. function.

[bboreham]

What I meant was: call logWithRequest once, then hold the resulting logging.Interface in a variable for the duration of the Wrap() inner function.
It's a relatively expensive operation:

common/middleware/logging.go

Lines 23 to 38 in 933588f

	func (l Log) logWithRequest(r *http.Request) logging.Interface {
	localLog := l.Log
	traceID, ok := tracing.ExtractTraceID(r.Context())
	if ok {
	localLog = localLog.WithField("traceID", traceID)
	}
	if l.SourceIPs != nil {
	ips := l.SourceIPs.Get(r)
	if ips != "" {
	localLog = localLog.WithField("sourceIPs", ips)
	}
	}
	return user.LogWith(r.Context(), localLog)
	}

[colin-stuart]

Thanks @bboreham, I see what you meant now!

[bboreham]

Looks better now, thanks. Have you tried it?

[colin-stuart]

Yep, enabled it for a service running locally and the requests logs are showing at the info level.