Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #86: bb test runner #103

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix #86: bb test runner #103

merged 1 commit into from
Aug 24, 2023

Conversation

borkdude
Copy link
Contributor

No description provided.

@borkdude borkdude mentioned this pull request Aug 17, 2023
Closed
3 tasks
@borkdude
Copy link
Contributor Author

@weavejester I updated this PR with the freshly released babashka version and should be ready for merge. Let me know if you want any changes.

weavejester
weavejester requested changes Aug 22, 2023
View reviewed changes
Copy link
Owner

@weavejester weavejester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and sorry it took a while to review! Aside from the minor changes requested, can you change the commit message to:

Add Babashka test runner (fixes #86)

Just to be more consistent with the existing commit log.

CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@borkdude
Copy link
Contributor Author

All processed, hopefully

@weavejester weavejester merged commit 01946f5 into weavejester:master Aug 24, 2023
1 check passed
@weavejester
Copy link
Owner

Perfect! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weavejester weavejester weavejester requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borkdude @weavejester