Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project version inferred from POT import for translation API #133

Merged
merged 5 commits into from
Nov 23, 2018

Conversation

swissspidy
Copy link
Collaborator

Description

Extracts and stores the version number from the Project-Id-Version header if it exists in a POT file.

The version number is then used in the translation API responses.

How has this been tested?

Added unit tests to document the behavior.

Types of changes
New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #133 into master will increase coverage by 0.28%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage        78%   78.28%   +0.28%     
- Complexity      333      341       +8     
============================================
  Files            23       23              
  Lines           800      815      +15     
============================================
+ Hits            624      638      +14     
- Misses          176      177       +1
Impacted Files Coverage Δ Complexity Δ
inc/TranslationApiRoute.php 100% <100%> (ø) 5 <0> (ø) ⬇️
inc/Project.php 100% <100%> (ø) 52 <4> (+4) ⬆️
inc/Updater.php 94.02% <85.71%> (-0.98%) 26 <3> (+4)
inc/ZipProvider.php 98.88% <0%> (+0.02%) 27% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074e9ba...3876286. Read the comment docs.

@swissspidy swissspidy changed the title Add/project version Use project version inferred from POT import for translation API Nov 21, 2018
inc/Project.php Outdated Show resolved Hide resolved
inc/Project.php Outdated Show resolved Hide resolved
@ocean90 ocean90 removed their assignment Nov 23, 2018
@swissspidy swissspidy merged commit e6eeee0 into master Nov 23, 2018
@delete-merged-branch delete-merged-branch bot deleted the add/project-version branch November 23, 2018 20:17
@grappler grappler added this to the 3.0.0 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants