Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include translations for JavaScript files in language packs #108

Merged
merged 16 commits into from
Nov 24, 2018

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Nov 10, 2018

This is supposed to fix #62.

As a first step parts of https://meta.trac.wordpress.org/changeset/7833/ are added to the ZipProvider class.

inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/ZipProvider.php Outdated Show resolved Hide resolved
That class handles the actual string export whereas the ZipProvider only compresses them
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #108 into master will increase coverage by 1.38%.
The diff coverage is 98.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     78.05%   79.43%   +1.38%     
- Complexity      333      354      +21     
============================================
  Files            23       24       +1     
  Lines           802      856      +54     
============================================
+ Hits            626      680      +54     
  Misses          176      176
Impacted Files Coverage Δ Complexity Δ
inc/ZipProvider.php 100% <100%> (+1.11%) 23 <0> (-4) ⬇️
inc/Export.php 98.61% <98.61%> (ø) 25 <25> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a580c45...0059a6f. Read the comment docs.

@swissspidy swissspidy added this to the 3.0.0 milestone Nov 20, 2018
@swissspidy
Copy link
Collaborator

@ocean90 What do you think of the current approach so far?

inc/ZipProvider.php Outdated Show resolved Hide resolved
inc/Export.php Outdated Show resolved Hide resolved
@swissspidy swissspidy changed the title [WIP] Include translations for JavaScript files in language packs Include translations for JavaScript files in language packs Nov 22, 2018
@swissspidy swissspidy requested a review from grappler November 22, 2018 13:28
@swissspidy
Copy link
Collaborator

@ocean90 Somehow I can't select you as a reviewer 🤔 Let me know what you think of the current PR.

@ocean90 ocean90 removed their assignment Nov 23, 2018
@swissspidy swissspidy merged commit c36b2ec into master Nov 24, 2018
@delete-merged-branch delete-merged-branch bot deleted the json-translations branch November 24, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Translation Files for WordPress 5.0
3 participants