-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include translations for JavaScript files in language packs #108
Conversation
That class handles the actual string export whereas the ZipProvider only compresses them
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
============================================
+ Coverage 78.05% 79.43% +1.38%
- Complexity 333 354 +21
============================================
Files 23 24 +1
Lines 802 856 +54
============================================
+ Hits 626 680 +54
Misses 176 176
Continue to review full report at Codecov.
|
@ocean90 What do you think of the current approach so far? |
@ocean90 Somehow I can't select you as a reviewer 🤔 Let me know what you think of the current PR. |
This is supposed to fix #62.
As a first step parts of https://meta.trac.wordpress.org/changeset/7833/ are added to the
ZipProvider
class.