Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERB Lint Support #363

Merged
merged 29 commits into from
Jan 6, 2022
Merged

Add ERB Lint Support #363

merged 29 commits into from
Jan 6, 2022

Conversation

ryanseamless
Copy link
Contributor

What's Changed

Add support for ERB Lint to lint ruby template files.

Callouts

  • These commits are a bit messy, let me know if they should be squashed before merging.
  • I've had to add commandArgs to the test params, erblint wasn't playing nice without specifying which files to test. I think this is appropriate, and could be useful for testing for other languages.
  • My test cases are very minimal, but seem in line with the tests for rubocop

Testing Notes
Added testing that roughly matches the test cases for rubocop. Everything passes. I've also been running this code from my fork with SeamlessMD's ERB files without issues

@ryanseamless ryanseamless marked this pull request as ready for review December 29, 2021 15:57
@ocean90 ocean90 added the enhancement New feature or request label Jan 6, 2022
@ocean90 ocean90 merged commit 8170c90 into wearerequired:master Jan 6, 2022
@ocean90
Copy link
Member

ocean90 commented Jan 6, 2022

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants