-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linter stdout/stderr assertions #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like these were incorrectly ported in wearerequired@73e9574 So the test suite (before this commit) wasn't actually asserting anything about the output.
The linter check doesn't seem to be checking out my branch properly (since it's on my fork, not on this repo):
|
samuelmeuli
requested changes
Feb 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks so much for these fixes @ascandella!
samuelmeuli
reviewed
Feb 9, 2020
The "Lint" workflow is currently failing because of #13, that's not an issue with your code :) |
samuelmeuli
changed the title
Fix linter stdout/stderr assertions in the test suite
Fix linter stdout/stderr assertions
Feb 9, 2020
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on a new linter that my test was passing even though the stdout/stderr was incorrect.
This seems to be fallout from this refactor:
73e9574
I had to update the timezone date regex to allow my timezone as well.
I also updated the
gofmt
linter, since it sends its output to stdout. I also fixed the tests for it.I updated the prettier test to remove the fix assertion on stdout because, on my machine, it outputs something like:
to stdout.