Support removing navigables from LazySetNavigator #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerin98
commented
Oct 23, 2024
Comment on lines
+67
to
+69
| if (navigablesToRemove.contains(currentNavigable)) { | ||
| handleCurrentTabRemoval() | ||
| } |
There was a problem hiding this comment.
There's an edge case to be aware of when removing a Navigable that is currently visible. We need to switch to another navigable before we can remove it because once you call removeFromLifecycle on a navigable you can't call replace on it anymore. I wrote a test updateMultipleNavigables_andRemoveCurrentNavigable describing this case.
Kritarie
reviewed
Oct 24, 2024
| lifecycleRegistry.attachToLifecycleWithMaxState(navigable, LifecycleLimit.CREATED) | ||
| } | ||
|
|
||
| public fun removeNavigables(navigables: Set<NavigableCompat>) { | ||
| for (navigable in navigables) { |
There was a problem hiding this comment.
Is there a risk of ConcurrentModificationException if one of the navigables tries to add / remove a navigable in its onDestroy ? I don't know enough about mutableSetOf to know if it allows concurrent modification
gerin98
force-pushed
the
allow-lazySetNavigator-to-remove-navigables
branch
from
c9fa578
to
2123832
Compare
gerin98
commented
Oct 24, 2024
| public fun removeNavigable(navigable: NavigableCompat) { | ||
| existingNavigables.removeIf { it == navigable } | ||
| if (lifecycleRegistry.children.contains(navigable)) { | ||
| lifecycleRegistry.removeFromLifecycle(navigable) |
There was a problem hiding this comment.
removeIf avoids ConcurrentModificationException but requires API level 24
Kritarie
approved these changes
Oct 25, 2024
kyeungk
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
LazySetNavigatorto remove navigables