Feat/various fixes #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @whitecolor , pls review |
staeke
force-pushed
the
feat/various-fixes
branch
from
9096075 to
f1f2c84
Compare
|
It would be better to split what possible, pls. |
|
@whitecolor sorry, missed your comment - will do |
This was referenced Oct 4, 2019
|
Separated out to other PRs so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
Feel free to have opinions on implementation. Maybe there should be on option around the SIGTERM -> SIGINT
Also, I went with sending the notification from
child-require-hook. Maybe it's cleaner to send something on IPC, and then notification. Any such comments - feel free to comment, and I'll fixAlso, as these are really 4 independent fixes, I could split them if preferred