Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R version 3.3.2 to checks for download_no_libcurl. #35

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Add R version 3.3.2 to checks for download_no_libcurl. #35

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b84ebe
Add R version 3.3.2 to checks for download_no_libcurl.
jacob-ogre Dec 6, 2016
af80d3a
Change R version check to >= 3.3.0 for no_libcurl.
jacob-ogre Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ available_port <- function(port) {
# 403 for HEAD requests. See
# https://stat.ethz.ch/pipermail/r-devel/2016-June/072852.html
download <- function(url, destfile, mode = "w") {
if (getRversion() == "3.3.0" || getRversion() == "3.3.1") {
if (getRversion() == "3.3.0" || getRversion() == "3.3.1" ||
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind changing it to just getRversion() >= "3.3.0"? I have a feeling that the issue isn't going to be fixed in R any time soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

getRversion() == "3.3.2") {
download_no_libcurl(url, destfile, mode = mode)

} else if (is_windows() && getRversion() < "3.2") {
Expand Down