Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 5.6 Support #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ironprogrammer
Copy link

This PR addresses the fatal errors identified in #58, and enables support for PHP 5.6.

Why Do This?

The Contributor Orientation Tool can be used by any community member -- not just developers, and not necessarily by someone who has much experience with WordPress. Hosting environments across the world can still vary, and because WordPress currently supports PHP 5.6, this is an easy fix to have one less barrier to contributing community members 🙌🏻.

Fixes errors on:
- admin (e.g. plugins page)
- plugin options page
- frontend
Enable plugin activation under PHP 5.6.
@2ndkauboy
Copy link
Contributor

I don't see a reason, why we should not easily support PHP 5.6 ... but then again, as this tool is only supposed to be used by WordCamp organizers, I don't think they really use such old and unsupported PHP versions. 🤔

I also don't know why the file dist/contributor-orientation-tool/src/WPCOTool/assets/js/shortcode.js needed to be changed.

@ironprogrammer
Copy link
Author

Thanks for your time, @2ndkauboy!

... but then again, as this tool is only supposed to be used by WordCamp organizers, I don't think they really use such old and unsupported PHP versions. 🤔

I agree that most organizers will probably use a newer version of PHP. But since WP still officially supports 5.6, this was a minor change to ensure parity with WP's support.

Community teams don't have a PHP requirement for their dev and prod environments, so this would help ensure they didn't run into issues if they're on an old version. Corner case, certainly.

I also don't know why the file dist/contributor-orientation-tool/src/WPCOTool/assets/js/shortcode.js needed to be changed.

Because the plugin includes the built source in 'dist', I re-ran the prod build script. In the process of doing so, the JS was recompiled, resulting in the updated file. If this isn't part of the contributor process for the project we can revert that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants