Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature xz-static has correctness issues within compression library #150

Open
wcampbell0x2a opened this issue Feb 16, 2023 · 1 comment
Open
Assignees

Comments

@wcampbell0x2a
Copy link
Owner

$ cargo build --release --bin unsquashfs --features xz-static
   Compiling backhand v0.9.1 (/home/wcampbell/projects/wcampbell/backhand)
    Finished release [optimized] target(s) in 2.73s

$ ./target/release/unsquashfs -f -d out-rust test-assets/test_openwrt_netgear_ex6100v2/bytes.squashfs
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: InvalidInput, error: Options }', src/bin/unsquashfs.rs:132:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

squashfs-tools/unsquashfs is just fine

$ unsquashfs test-assets/test_openwrt_netgear_ex6100v2/bytes.squashfs
Parallel unsquashfs: Using 8 processors
1249 inodes (1049 blocks) to write


create_inode: could not create character device squashfs-root/dev/console, because you're not superuser!
[================================================================================================================================================================================================================================================================================================================================================| ] 2297/2298  99%

created 1043 files
created 122 directories
created 205 symlinks
created 0 devices
created 0 fifos
created 0 sockets
created 0 hardlinks
@wcampbell0x2a
Copy link
Owner Author

Also linked: alexcrichton/xz2-rs#105

@wcampbell0x2a wcampbell0x2a self-assigned this Feb 17, 2023
wcampbell0x2a added a commit that referenced this issue May 31, 2023
This ony fixes the static issue for the binaries built in this repo, you
will need to define these yourself if using backhand as a library!

See:
- #150
- alexcrichton/xz2-rs#105
- alexcrichton/xz2-rs#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant