Update deku #9
Open
Update deku #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
wcampbell0x2a
force-pushed
the
update-deku
branch
from
9a227fb to
0d80955
Compare
wcampbell0x2a
force-pushed
the
update-deku
branch
from
0d80955 to
5830b5c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 68.22% 68.45% +0.23%
==========================================
Files 9 9
Lines 406 409 +3
Branches 406 409 +3
==========================================
+ Hits 277 280 +3
Misses 46 46
Partials 83 83 ☔ View full report in Codecov by Sentry. |
wcampbell0x2a
force-pushed
the
update-deku
branch
2 times, most recently
from
b88f41f to
95b58db
Compare
wcampbell0x2a
commented
Dec 28, 2023
| let mut v = vec![]; | ||
| let mut cursor = Cursor::new(&mut v); | ||
| let mut writer = Writer::new(&mut cursor); | ||
| message.to_writer(&mut writer, (deku::ctx::Endian::Big, 0)).unwrap(); |
There was a problem hiding this comment.
Such a slow way of updating the crc -_-
wcampbell0x2a
force-pushed
the
update-deku
branch
from
95b58db to
ec4c603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.