Add "JSON Key-Value" package #5496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your package relies on PackageDev, which is a bad idea. Ideally, Sublime Text by itself would highlight keys different from regular strings. There already are different meta scopes, but they don't allow a selector to specifically target them. I opened an issue upstream for this: sublimehq/Packages#421. If you remove the unnecessary dependency on PackageDev I'll merge the package because it is also compatible with ST2. |
|
OK. I'll remove the dependency so that this can be used in the interim before a fix, and for ST2. Thanks! |
|
Please open a new PR once you are done with updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.