Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate definition of RecipientKeyIdentifier #266

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Fix duplicate definition of RecipientKeyIdentifier #266

merged 3 commits into from
Oct 12, 2023

Conversation

wbond
Copy link
Owner

@wbond wbond commented Sep 2, 2023

Potential fix for #243 that needs a test

@@ -729,6 +729,10 @@ class RecipientKeyIdentifier(Sequence):
('other', OtherKeyAttribute, {'optional': True}),
]

def _setup(self):
super(RecipientKeyIdentifier, self)._setup()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super()._setup() should be fine

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project targets Python 2.6+ currently, hence the parameters passed to super.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected as 2.6 has been EOL for 9, 2.7 for 3 years, but you'll have your reasons.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’m more interested in tests for the code you added

@wbond wbond merged commit 8609892 into master Oct 12, 2023
53 checks passed
@wbond wbond deleted the ski_fix branch November 3, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants