cleanup interface (#162)

examples/contract_details.rs

@@ -10,8 +10,7 @@ fn main() -> anyhow::Result<()> {
     println!("connection_time: {:?}", client.connection_time());
     println!("next_order_id: {}", client.next_order_id());
 
-    let mut contract = Contract::stock("AAPL");
-    contract.currency = "USD".to_string();
+    let contract = Contract::stock("MSFT");
 
     let results = client.contract_details(&contract)?;
     for contract in results {

src/client.rs

@@ -356,8 +356,8 @@ impl Client {
     ///     println!("contract: {:?}", contract_detail);
     /// }
     /// ```
-    pub fn contract_details(&self, contract: &Contract) -> Result<impl Iterator<Item = contracts::ContractDetails>, Error> {
-        Ok(contracts::contract_details(self, contract)?.into_iter())
+    pub fn contract_details(&self, contract: &Contract) -> Result<Vec<contracts::ContractDetails>, Error> {
+        Ok(contracts::contract_details(self, contract)?)
     }
 
     /// Get current [FamilyCode]s for all accessible accounts.

src/contracts/tests.rs

@@ -27,7 +27,7 @@ fn request_stock_contract_details() {
 
     assert!(results.is_ok(), "failed to encode request: {:?}", results.err());
 
-    let contracts: Vec<ContractDetails> = results.unwrap().collect();
+    let contracts: Vec<ContractDetails> = results.unwrap();
     assert_eq!(2, contracts.len());
 
     assert_eq!(contracts[0].contract.exchange, "SMART");