allow setting color of table borders #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +21,7 @@ def initialize(options = {}) | |||
| def add(row) | |||
| # Inheritance from the table | |||
| row.border = self.border | |||
| row.border_color = self.border_color | |||
There was a problem hiding this comment.
Redundant self detected.
swap byebug for debugger in gemspec, see cldwalker/debugger#125
lastobelus
force-pushed
the
table_border_color
branch
from
446ff3b
to
a59d00e
Compare
|
I matched your code style, but should I listen to houndci instead? |
|
Good question. I am about to turn hound off so let's leave it with my style based on the comments I've seen here. |
wbailey
added a commit
that referenced
this pull request
Oct 23, 2014
allow setting color of table borders
|
Also, can you update the wiki to include the documentation for how to change the border color? If we do that I can push a new release! Thanks for the work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swap byebug for debugger in gemspec, see cldwalker/debugger#125