Vulnerability Detector: Compared vendor with official vendors #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimegar
force-pushed
the
6435-comparison-packages-different-vendor
branch
from
a9b246e to
b81be5c
Compare
chemamartinez
suggested changes
Nov 16, 2020
src/unit_tests/wazuh_modules/vulnerability_detector/test_wm_vuln_detector.c
Outdated
Show resolved
Hide resolved
src/unit_tests/wazuh_modules/vulnerability_detector/test_wm_vuln_detector.c
Outdated
Show resolved
Hide resolved
src/unit_tests/wazuh_modules/vulnerability_detector/test_wm_vuln_detector.c
Outdated
Show resolved
Hide resolved
chemamartinez
suggested changes
Nov 18, 2020
| @@ -1897,6 +1904,11 @@ int wm_vuldet_linux_oval_vulnerabilities(sqlite3 *db, agent_software *agents_it, | |||
| version = src_version; | |||
| } | |||
|
|
|||
| // We discard the package if its vendor is a external vendor. | |||
| if (agents_it->dist == FEED_REDHAT && vendor && wm_vuldet_compare_vendors(vendor)) { | |||
| continue; | |||
There was a problem hiding this comment.
Include a debug2 message here to know the package has been discarded, including the vendor
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have created a function that compares the package's vendor with the official vendors from de OVAL feeds. If the vendor does not match with any of them, the package is discarded.
Tests