Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed group report false configuration parameter #1271

Merged
merged 6 commits into from
Feb 16, 2022

Conversation

asteriscos
Copy link
Member

Hi team,

this fixes a python exception when some PDF report options where not selected. Also fixes the documentation url to use current version instead of a fixed one.

Closes #1247 #1093

To test it:

  • Go to Management / Groups
  • Edit a group configuration with some example configuration like the following and save it:
    <agent_config name="agent_name"> <localfile> <location>/var/log/my.log</location> <log_format>syslog</log_format> </localfile> </agent_config> <agent_config os="Linux"> <localfile> <location>/var/log/linux.log</location> <log_format>syslog</log_format> </localfile> </agent_config> <agent_config profile="database"> <localfile> <location>/var/log/database.log</location> <log_format>syslog</log_format> </localfile> </agent_config>
  • Select that group a generate different PDF report with different options selected

image

@asteriscos asteriscos self-assigned this Feb 15, 2022
@AlexRuiz7 AlexRuiz7 linked an issue Feb 16, 2022 that may be closed by this pull request
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✔️
Test ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Test ✅

@Machi3mfl Machi3mfl self-requested a review February 16, 2022 17:14
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

@Machi3mfl
Copy link
Member

Fixed
Screen Shot 2022-02-16 at 14 13 23

@AlexRuiz7 AlexRuiz7 merged commit 94afdc9 into 4.3-8.2 Feb 16, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/pdf-group-report-configuration-1247 branch February 17, 2022 10:06
@AlexRuiz7 AlexRuiz7 linked an issue Feb 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF group reports are blank Group PDF report is a blank page
4 participants