Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-sortable columns on the Security section tables #1260

Conversation

AlexRuiz7
Copy link
Member

Summary

This PR fixes sorting issues on the Security section tables, as some columns were able to be sorted when it shouldn't.

To test

Simply go to the Security sections and check the sorting on the table. Check that no error occurs.

The following columns must not be sortable:

  • Users : run_as, roles
  • Roles : policies
  • Role Mapping : roles

@AlexRuiz7 AlexRuiz7 self-assigned this Feb 14, 2022
@AlexRuiz7 AlexRuiz7 added the 4.3 label Feb 14, 2022
@AlexRuiz7 AlexRuiz7 linked an issue Feb 14, 2022 that may be closed by this pull request
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
TEST: ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Code review ✅
Test ✅

@AlexRuiz7 AlexRuiz7 merged commit b3cf987 into 4.3-8.2 Feb 15, 2022
@AlexRuiz7 AlexRuiz7 deleted the bugfix/1259-fix-nonsortable-columns-on-security-section-tables branch February 15, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid sort fields used in the Security section tables
3 participants