Added condition for destroy #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptionv
Using an user with no permissions to enter the Agents section produces an error on the controller. There is already a component with such DOM element's ID.
Resolve:
Added destroy if
this.linearChartAgentexists to callthis.linearChartAgent.destroy(), which did not allow doingthis.topAgent.destroy()Steps to reproduce
Using RBAC and an user with no agents:read permissions:
1.Open the browser's Dev Tools (F12) and Console
2.Go to 'Agents' view
3.The App is hidden (Ok)
4.Navigate out of Agents and then back in.
5.See that no error appears
Close:
searchTopAgent component failes to be re-initiailized #1222
Screenshot: