Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added persistence from within a cluster #1146

Merged
merged 13 commits into from
Jan 19, 2022

Conversation

mpRegalado
Copy link
Member

This PR is a direct enhancement of #1135
With these changes, the current extension state is saved to the Splunk Database instead of to a local file. This means that multiple installations of the plugin will read data from a single origin, achieving a consistent state.

Closes #1142

To test

These same tests should work identically when navigating to Agent Extensions instead of Overview Welcome.
Tests should work either in a single installation or across multiple search heads.
Fresh start

  • Given a new API has been set up
  • And There is no extensions data in session storage
  • When The user navigates to Overview/Welcome for the first time
  • Then Extensions load as described in SplunkAppForWazuh/default/config.conf
  • And Extensions data is added to session storage

Enabling an extension

  • Given the browser is in Overview/Welcome
  • When the user enables an extension
  • Then the extension appears in the menu

Reloading form same session

  • Given there is Extensions data in session storage
  • And the extensions have been modified previously
  • When the browser navigates to Overview/Welcome
  • Then extensions load to match previous changes

Reloading from a new session

  • Given there is no extensions data in session storage
  • And this API's extensions have been modified previously
  • When the user navigates to Overview/Welcome
  • Then extensions load to match previous changes
  • And an entry in extensions data is added with identical information to the one added in a fresh start

Removing an API

  • Given there is an API set up
  • And there is extension data in session storage
  • When the user removes an API
  • Then extension data for this API is removed from session storage

@mpRegalado mpRegalado requested a review from a team October 6, 2021 10:47
@mpRegalado mpRegalado self-assigned this Oct 6, 2021
@mpRegalado mpRegalado linked an issue Oct 6, 2021 that may be closed by this pull request
mpRegalado and others added 2 commits October 6, 2021 12:49
Combined similar features added into a single lne
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!
Testing: LGTM!

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MauGaP MauGaP self-assigned this Oct 18, 2021
@eze9252 eze9252 changed the base branch from 4.1-8.1 to 4.3-8.2 November 25, 2021 15:01
@eze9252 eze9252 added the 4.3 label Nov 25, 2021
@asteriscos asteriscos merged commit f8a32e6 into 4.3-8.2 Jan 19, 2022
@AlexRuiz7 AlexRuiz7 deleted the enhancement/1142_persistence-within-cluster branch January 28, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync extensions between cluster members
7 participants