Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent status visualization #1140

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Agent status visualization #1140

merged 9 commits into from
Sep 29, 2021

Conversation

gabiwassan
Copy link
Contributor

@gabiwassan gabiwassan commented Sep 28, 2021 •
edited
Loading

Hi team,
This PR implements the new card with Agent Status in the Agents view.

image

Close: #1113

@gabiwassan gabiwassan self-assigned this Sep 28, 2021
frankeros
frankeros approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

@MauGaP
Copy link
Contributor

MauGaP commented Sep 28, 2021

The disposition of the graphic is not responsive: fixing this should need a better implementation of responsiveness on all other sections of the page (Status and Details)
image
in this image, the resolution of the page is 952px x 988px
Severity: 3

The buttons have tooltips that are not displayed aligned to the button placement
tooltips
The black tooltip should be over the magnifying glass icon. This behaviour is the same for all the other graphics under overview section.
Severity: 3

When the graphic is maximized and you click the refresh button, the graphic is refreshed and reverts to its previous size
image
This happens with all other graphics of this type
Severity: 4

When the graphic is maximized and you click the download button, the download modal opens in the back of the maximized graph
Severity: 3

asteriscos
asteriscos approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@frankeros frankeros merged commit d35ca38 into 4.1-8.1 Sep 29, 2021
@frankeros frankeros deleted the feat/1113-agent-status-visualization branch September 29, 2021 21:07
@AlexRuiz7 AlexRuiz7 linked an issue Jan 28, 2022 that may be closed by this pull request
[Feature request] Agent status visualization over time in the Agent tab #1113
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@frankeros frankeros frankeros approved these changes

Assignees

@gabiwassan gabiwassan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Agent status visualization over time in the Agent tab
4 participants
@gabiwassan @MauGaP @asteriscos @frankeros