Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on save rules or decoders files #1138

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Sep 27, 2021

Description:

Error 404 appears when editing the rules file and endless Loader when editing decoder files.

Resolve:

In the rules change the saveRuleConfig function the dir in the controller and for decoders change the parameter that sends the saveDecoderConfig function in the html and also in the controller of that function change the dir in the controller.

Test:

Edit custom rules/decoders and save them

Close: 1095

@gabiwassan gabiwassan changed the title changes in decoders and rules Fix on save rules or decoders files Sep 28, 2021
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Missing changelog, LGTM otherwise
Testing: LGTM ✔️

@yenienserrano yenienserrano self-assigned this Oct 18, 2021
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

Changelog entry could be better, but that's not a stopper.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

@eze9252 eze9252 changed the base branch from 4.2-8.1 to 4.3-8.2 November 25, 2021 15:00
@eze9252 eze9252 linked an issue Nov 25, 2021 that may be closed by this pull request
@AlexRuiz7 AlexRuiz7 added the 4.3 label Jan 14, 2022
@asteriscos asteriscos merged commit 19ecd51 into 4.3-8.2 Jan 19, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/1095-changes-in-rules-and-decoders branch January 28, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot save rules or decoders file
4 participants