-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on save rules or decoders files #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Missing changelog, LGTM otherwise
Testing: LGTM ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: ✔️
CR: ✔️
Changelog entry could be better, but that's not a stopper.
SplunkAppForWazuh/appserver/static/js/controllers/management/decoders/manager-decoders-id.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: ✔️
CR: ✔️
Description:
Error 404 appears when editing the rules file and endless Loader when editing decoder files.
Resolve:
In the rules change the saveRuleConfig function the dir in the controller and for decoders change the parameter that sends the saveDecoderConfig function in the html and also in the controller of that function change the dir in the controller.
Test:
Edit custom rules/decoders and save them
Close: 1095