Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forwarder connection error toast in search handler #1021

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 22, 2021

Hi team,

this adds an error toast when the search-handler is unable to get results.
Also, a raw HTML code in some cards was fixed
image

Closes #1010

@asteriscos asteriscos requested a review from a team March 22, 2021 21:30
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos self-assigned this Mar 29, 2021
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 3d471bd into 4.0-8.1 Mar 29, 2021
@frankeros frankeros deleted the bugfix/forwarder-connection-error-toast-in-search-handler branch March 29, 2021 19:41
frankeros pushed a commit that referenced this pull request Apr 12, 2021
* Add toast when search-handler fails to process a query

* Code cleaning

* Parse HTML from plain text description

* Comments cleaning

* Update error message
@frankeros frankeros mentioned this pull request Apr 12, 2021
Machi3mfl added a commit that referenced this pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants