Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Wazuh changes #1

Closed
wants to merge 15 commits into from
Closed

Introduce Wazuh changes #1

wants to merge 15 commits into from

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Feb 8, 2023

Description

This pull request introduce the Wazuh changes to the repository.

The following list of changes have been applied:

  • Replace OpenSearch login default configuration title with Wazuh login title text.
  • Replace OpenSearch login logo with Wazuh login logo.
  • Replace OpenSearch login title with Wazuh login title.
  • Replace OpenSearch login subtitle with Wazuh login subtitle.
  • Disable first time pop-up tenant selector.
  • Replace home logo.

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AlexRuiz7 AlexRuiz7 linked an issue Feb 8, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🟢
CR: 🟡

image

@Tostti Tostti force-pushed the Introduce-Wazuh-changes branch from 5271434 to 1037757 Compare March 8, 2023 12:11
@AlexRuiz7
Copy link
Member Author

We are going to distribute the changes of this pull request:

  • Visual changes: CSS styles, images and texts.
  • Disable multi-tenancy
  • Accommodate tests

@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 20, 2023
4 tasks
@chantal-kelm chantal-kelm self-requested a review April 28, 2023 15:14
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Captura de pantalla 2023-04-28 a la(s) 12 14 05

Copy link
Member Author

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes from this pull request have been ported to individual PRs

See the comments. Rest of the stuff is in #3

.github/actions/install-dashboards/action.yml Outdated Show resolved Hide resolved
.github/workflows/cypress-test.yml Outdated Show resolved Hide resolved
Comment on lines 239 to 251
// As we disabled the opensearch_dashboards_overview in Wazuh Dashboard, this test will never success

const cookie = await driver.manage().getCookies();
expect(cookie.length).toEqual(2);
await driver.manage().deleteAllCookies();
await driver.quit();
});
// it('Login to app/opensearch_dashboards_overview#/ when SAML is enabled', async () => {
// const driver = getDriver(browser, options).build();
// await driver.get('http://localhost:5601/app/opensearch_dashboards_overview#/');
// await driver.findElement(By.id('btn-sign-in')).click();
// await driver.wait(until.elementsLocated(By.xpath(pageTitleXPath)), 10000);

// const cookie = await driver.manage().getCookies();
// expect(cookie.length).toEqual(2);
// await driver.manage().deleteAllCookies();
// await driver.quit();
// });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with block comment to reduce collisions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

const driver = getDriver(browser, options).build();
// We can't run this test because we have no data in the dashboard by default to test.
// it('Login to Dashboard with Hash', async () => {
// const urlWithHash = `http://localhost:5601/app/dashboards#/view/7adfa750-4c81-11e8-b3d7-01146121b73d?_g=(filters:!(),refreshInterval:(pause:!f,value:900000),time:(from:now-24h,to:now))&_a=(description:'Analyze%20mock%20flight%20data%20for%20OpenSearch-Air,%20Logstash%20Airways,%20OpenSearch%20Dashboards%20Airlines%20and%20BeatsWest',filters:!(),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:''),timeRestore:!t,title:'%5BFlights%5D%20Global%20Flight%20Dashboard',viewMode:view)`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported to #5

@AlexRuiz7 AlexRuiz7 closed this May 10, 2023
@AlexRuiz7 AlexRuiz7 removed a link to an issue May 10, 2023
4 tasks
@AlexRuiz7 AlexRuiz7 linked an issue May 10, 2023 that may be closed by this pull request
4 tasks
@AlexRuiz7 AlexRuiz7 deleted the Introduce-Wazuh-changes branch May 10, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Wazuh changes
4 participants