-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix allocation bug instance connection error #5216
Merged
teddytpc1
merged 7 commits into
4495-dtt1-release
from
enhancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
Apr 17, 2024
Merged
Fix allocation bug instance connection error #5216
teddytpc1
merged 7 commits into
4495-dtt1-release
from
enhancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauldpm
requested changes
Apr 16, 2024
rauldpm
requested changes
Apr 16, 2024
…hancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
rauldpm
approved these changes
Apr 16, 2024
rauldpm
changed the title
Enhancement/5198 dtt1 allocation bug instance connection error to4495 dtt1 release
Fix allocation bug instance connection error
Apr 16, 2024
fcaffieri
approved these changes
Apr 17, 2024
teddytpc1
deleted the
enhancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
branch
April 17, 2024 15:49
c-bordon
restored the
enhancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
branch
April 19, 2024 12:19
teddytpc1
deleted the
enhancement/5198-dtt1-allocation-bug-instance-connection-error-to4495-dtt1-release
branch
April 19, 2024 12:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #5198
A connectivity validation method is created after provisioning, this validation is carried out through
SSH
orWINRM
depending on the system. When the module finishes executing it is because the machine is provisioned and has connectivity, therefore, it is ready to use.Several tests were carried out and they were used to correct some errors in the Windows userData and the general Windows configuration. As well as in the process of eliminating Windows instances.
The validation process has an automatic rollback, that is, if after 15 retries with a time between attempts of 60 seconds the instance does not connect, a rollback is automatically performed and the instance is deleted. This rollback can be disabled with the
--rollback
argument set toFalse
Testing
Test with rollback: #5198 (comment)
Test without rollback: #5198 (comment)
Test PowerPC: #5198 (comment)
Test macOS Intel: #5198 (comment)
Test macOS ARM: #5198 (comment)
Test Linux: #5198 (comment)
Test Windows Server 2012 R2: #5198 (comment)
Test Windows Server 2016: #5198 (comment)
Test Windows Server 2019: #5198 (comment)
Test Windows Server 2022: #5198 (comment)
Test Windows desktop 10: #5198 (comment)
Test Windows desktop 11: #5198 (comment)