-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/4940 dtt1 provision multiple dependencies inventories #4946
Enhancement/4940 dtt1 provision multiple dependencies inventories #4946
Conversation
…module-improvements-and-fixes' into enhancement/4940-dtt1-provision-multiple-dependencies-inventories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Notes
Small changes requested
deployability/launchers/provision.py
Outdated
parser.add_argument("--inventory-agent", default=None, help="Inventory with agent host information") | ||
parser.add_argument("--inventory-manager", default=None, help="Inventory with manager host information") | ||
parser.add_argument("--inventory", default=None, help="Inventory with agent host information") | ||
parser.add_argument("--dependencies", action='append',required=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies do not have help information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated on commit 2962694
@@ -12,7 +12,7 @@ class ComponentType(ABC): | |||
component (str): The component to be provisioned. | |||
type (str): The type of the component. | |||
version (str): The version of the component. | |||
manager_ip (str): The manager IP to be used in the provision. | |||
dependencies (str): The manager IP to be used in the provision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would change to: Dependencies that will be used as a manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated on commit 2962694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Notes
Some conflicts are present.
…-fixes' into enhancement/4940-dtt1-provision-multiple-dependencies-inventories
Review NotesLGTM, conflicts were solved. |
Description
This PR implements the multi dependencies option for the provision module. It can be used when we provision a
worker
of a cluster that requires info from themaster
or a complete installation where we require the IPs of the dashboard, servers & indexers.Usage
Now the provision module accepts the optional argument
dependencies
which is a list of dicts or a dict. Example:[{'manager': 'path/to/inventory.yaml'}, {'agent': 'path/to/inventory.yaml'}]
{'manager': 'path/to/inventory.yaml', 'agent': 'path/to/inventory.yaml'}
So, implemented in a task of the workflow it looks like this:
Testing performed
Provision without the dependencies
Provision with dependencies