E2E tests: Fix Brute Force tests #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmv74211
suggested changes
Sep 1, 2022
...d/test_basic_cases/test_brute_force/test_brute_force_ssh/data/playbooks/generate_events.yaml
Outdated
Show resolved
Hide resolved
...d/test_basic_cases/test_brute_force/test_brute_force_ssh/data/playbooks/generate_events.yaml
Outdated
Show resolved
Hide resolved
...d/test_basic_cases/test_brute_force/test_brute_force_rdp/data/playbooks/generate_events.yaml
Outdated
Show resolved
Hide resolved
...d/test_basic_cases/test_brute_force/test_brute_force_rdp/data/playbooks/generate_events.yaml
Outdated
Show resolved
Hide resolved
jmv74211
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I fixed the
test_brute_force_rdptest by specifying the version of Hydra to be installed (v9.2).Also, I added a role task to search for the alert before fetching the
alerts.json.Added
search_alert.yamlrole taskUpdated
Testing performed
failed_whencondition because it's unnecessary (the command is executed but ansible does not wait for it to finish)