Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT FIM - Fix Solaris and Macos test_basic_usage_realtime_usupported fails #2974

Closed
wants to merge 9 commits into from

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Jun 7, 2022

Related issues #2881

Description

During runs of the Nightly pipeline, it was found that the test module test_basic_usage_realtime_unsupported.py was having flaky behaviour, on Solaris OS. This PR applies a fix to that test, as well as two other modules that also presented flaky behaviour during testing.

Also, during testing it was found that the modify_file_inode function on the deps/wazuh_testing/fim.py module would cause OS ERROR 18: Invalid cross device link on some systems, because of the function os.replace. The function was replaced by shutil.move, that has the same functionality and parameters but does not generate this error.


Affected Test Modules

  • test_fim/test_files/test_basic_usage/test_basic_usage_realtime_unsupported.py
  • test_fim/test_files/test_follow_symbolic_link/test_change_target.py
  • test_fim/test_files/test_follow_symbolic_link/test_delete_symlink.py
  • test_fim/test_files/test_follow_symbolic_link/test_monitor_symlink.py

Configuration options

OS Version Branch Type
Solaris 4.3.4 master Agent
MacOs 4.3.4 master Agent

Local Internal Options:

Agent

syscheck.debug=2
agent.debug=2
windows.debug=2
monitord.rotate_log=0


Tests Results

Test Path Os/Type Local Jenkins Date By
test_fim/test_synchronization/ Windows 🟢 🟢 🟢 🟢 🟢 🟢 06/06/2022 @Deblintrake09

Required

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.

@Deblintrake09 Deblintrake09 linked an issue Jun 7, 2022 that may be closed by this pull request
@Deblintrake09 Deblintrake09 marked this pull request as ready for review June 7, 2022 16:29
@damarisg damarisg removed the request for review from CamiRomero June 7, 2022 19:43
damarisg
damarisg previously approved these changes Jun 7, 2022
@Deblintrake09 Deblintrake09 changed the base branch from master to 4.4 June 8, 2022 12:00
@Deblintrake09 Deblintrake09 changed the base branch from 4.4 to 4.3 June 8, 2022 12:00
@Deblintrake09 Deblintrake09 changed the base branch from 4.3 to master June 8, 2022 12:00
@Deblintrake09 Deblintrake09 dismissed damarisg’s stale review June 8, 2022 12:00

The base branch was changed.

@Deblintrake09 Deblintrake09 requested a review from damarisg June 8, 2022 12:01
@Deblintrake09 Deblintrake09 self-assigned this Jun 8, 2022
@Deblintrake09
Copy link
Contributor Author

Closing issue because this has been solved in PR #2976. It will be merged from 4.4 to master.

@Deblintrake09 Deblintrake09 deleted the 2881-solaris-fim-fail branch June 9, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solaris FIM IT : test_realtime_unsupported fail
2 participants