Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jobflow examples #5615

Closed
rauldpm opened this issue Jul 25, 2024 · 6 comments · Fixed by #5680
Closed

Fix Jobflow examples #5615

rauldpm opened this issue Jul 25, 2024 · 6 comments · Fixed by #5680
Assignees
@pro-akim
Labels
level/task Task issue type/bug

Comments

@rauldpm
Copy link
Member

rauldpm commented Jul 25, 2024 •
edited
Loading

Description

We need to review the Jobflow examples as some YAML set Windows instances size to small instead of large, which causes the instance to fail

We need to change the examples so we have a main template outside the examples directory, for example in:

deployability/modules/jobflow/templates

This directory should contain the following YAML

  • Complete agent test
  • Complete manager test
  • Complete central component test

Those YAML should not reference any version or revision values (instead of 4.8.0 it must say: major.minor.patch

We need to check the depends_on references as:

  • manager provision should depend on manager allocation
  • agent deployment should depend on manager provision or allocation
  • clean is successful

Related
@wazuhci wazuhci moved this to Backlog in Release 4.9.0 Jul 25, 2024
@rauldpm rauldpm mentioned this issue Jul 25, 2024
Closed
1 task
@juliamagan juliamagan mentioned this issue Jul 29, 2024
Closed
@pro-akim pro-akim self-assigned this Jul 31, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.9.0 Jul 31, 2024
@pro-akim
Copy link
Member

pro-akim commented Jul 31, 2024 •
edited
Loading

Update

  • Windows instances size small
  • Located in: deployability/modules/jobflow/templates
  • Contains [Complete agent test, Complete manager test, Complete central component test]
  • YAML do not reference any version or revision values (It says major.minor.patch)
  • The depends_on references checked
  • Testing the examples

@pro-akim
Copy link
Member

Update

Moved to on-hold due to https://github.com/wazuh/wazuh-jenkins/issues/6775

@wazuhci wazuhci moved this from In progress to On hold in Release 4.9.0 Jul 31, 2024
pro-akim added a commit that referenced this issue Jul 31, 2024
@pro-akim
enhancement(#5615): Adding templates
f8eb43d
This was referenced Aug 7, 2024
Closed
Closed
@wazuhci wazuhci moved this from On hold to In progress in Release 4.9.0 Aug 14, 2024
@pro-akim
Copy link
Member

Update

While testing, I found that Windows-Desktop-10, on several occasions, times out after being started.
agent_01.txt

Further testing will be done to upload 100% working YAMLs

@pro-akim
Copy link
Member

Test results:

CC 🟢
central.txt

Manager 🟢
manager.txt

Agent 🟢
agent.txt

pro-akim added a commit that referenced this issue Aug 16, 2024
@pro-akim
enhancement(#5615): Jobflow examples
f7178e8
@pro-akim pro-akim linked a pull request Aug 16, 2024 that will close this issue
Adding jobflow templates #5680
Merged
pro-akim added a commit that referenced this issue Aug 16, 2024
@pro-akim
enhancement(#5615): replacement version to major.minor.patch
3f979d3
pro-akim added a commit that referenced this issue Aug 16, 2024
@pro-akim
fix(#5615): Line breaks
ad40d96
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Aug 16, 2024
@juliamagan juliamagan mentioned this issue Aug 16, 2024
Closed
@wazuhci wazuhci moved this from Pending review to On hold in Release 4.9.0 Aug 16, 2024
pro-akim added a commit that referenced this issue Aug 16, 2024
@pro-akim
fix(#5615): Adding abort all
0424a1f
@pro-akim
Copy link
Member

Updates

Changes done after review

@wazuhci wazuhci moved this from On hold to Pending review in Release 4.9.0 Aug 16, 2024
@fcaffieri
Copy link
Member

LGTM

@wazuhci wazuhci moved this from Pending review to Pending final review in Release 4.9.0 Aug 16, 2024
@wazuhci wazuhci moved this from Pending final review to In final review in Release 4.9.0 Aug 19, 2024
damarisg pushed a commit that referenced this issue Aug 19, 2024
@pro-akim
Adding jobflow templates (#5680)
2ff1805 
* enhancement(#5615): Jobflow examples

* enhancement(#5615): replacement version to major.minor.patch

* fix(#5615): Line breaks

* fix(#5615): Adding abort all
@damarisg damarisg moved this from In final review to Done in Release 4.9.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pro-akim pro-akim

Labels
level/task Task issue type/bug
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding jobflow templates wazuh/wazuh-qa
4 participants
@damarisg @rauldpm @fcaffieri @pro-akim