Skip certificate validation for CentOS 5 package generation #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dwordcito
approved these changes
Mar 27, 2024
vikman90
approved these changes
Mar 27, 2024
MarcelKemp
force-pushed
the
2889-fix-ssl-verification
branch
from
3153fe6 to
a2e3825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the certificate validation problem for the CentOS 5 case, because the certificates for this OS are no longer valid.
To avoid this problem, we have simply skipped the certificate verification for the failed case. This way it no longer fails and can continue with the generation of the package.
The problem has only been seen on the
i386architecture, so it has only been tested for this. However, this can also happen onx86_64, so we can also generate an image with this change to avoid future problems.Tests