Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The option to change the logo for custom branding is not working #1886

Closed
2 tasks done
c-bordon opened this issue Oct 14, 2022 · 4 comments
Closed
2 tasks done

The option to change the logo for custom branding is not working #1886

c-bordon opened this issue Oct 14, 2022 · 4 comments

Comments

@c-bordon
Copy link
Member

c-bordon commented Oct 14, 2022

Description

When trying to make a customization in Wazuh dashboard and replace the Wazuh logos with custom logos, it was detected that the Logo of the landing page is not being changed:
image
image

Tasks

  • Analyze in the construction of the base that another way we can pass the Wazuh Logo without affecting the customization

Validation

  • The new package must have the Wazuh logo by default and it must be possible to replace it with any svg image
@rauldpm
Copy link
Member

rauldpm commented Nov 2, 2022

Update report

Research

  • The packages have been built to perform an AIO installation and try to reproduce the reported problem:
    • Revision: wp.1886
    • Repository: warehouse-test
Package Build File
Wazuh dashboard app https://devel.ci.wazuh.info/view/Packages/job/Packages_builder/8921/ wazuh-4.4.0-wp.1886.zip
Wazuh server https://devel.ci.wazuh.info/job/Packages_builder/8923/ wazuh-manager-4.4.0-wp.1886.x86_64.rpm
Wazuh indexer https://devel.ci.wazuh.info/job/Packages_builder/8924/ wazuh-indexer-4.4.0-wp.1886.x86_64.rpm
Wazuh dashboard https://devel.ci.wazuh.info/job/Packages_builder/8925/ wazuh-dashboard-4.4.0-wp.1886.x86_64.rpm
  • The build of the Wazuh dashboard package has failed with the following error:
18:11:39  gzip: stdin: not in gzip format
18:11:39  tar: Child returned status 1
18:11:39  tar: Error is not recoverable: exiting now
  • This error is usually due to not finding the Wazuh dashboard app in the AWS S3 bucket, but the generated Wazuh dashboard app file exits in the S3 bucket, upon investigation, this error may be due to a lack of updating the Docker image in AWS ECR.
  • New images have been built and uploaded to AWS ECR.
  • After updating the images, a new build has been launched which has finished successfully (See the table above).
  • After an initial installation using the Wazuh dashboard package, it has been verified that the customization options offered by OpenSearch in the OpenSearch Dashboards configuration do not include the login screen logo, investigating the OpenSearch documentation the following has been found:
Setting Corresponding branding element
logo Header logo. See 1 in the image.
mark OpenSearch Dashboards mark. See 2 in the image.
loadingLogo Loading logo used when OpenSearch Dashboards is starting. See 3 in the image.
faviconUrl Website icon. Loads next to the application title. See 4 in the image.
applicationTitle The application's title. See 5 in the image.

image

  • The inability to modify the login screen logo using the Wazuh dashboard package has been replicated in the OpenSearch Dashboards 2.3.0 package itself.

Information related to OpenSearch custom branding

By @peternied: Thanks @kgcreative it looks like we missed adding this customization logic into the login screen, thanks for referencing that pull request.

Conclusion

  • Due to what is reported in this comment, the possible actions to take are:
    • Modify the source files of the OpenSearch Dashboards package, for example, by using sed and adding a parameter to specify the file to use.
    • Wait for OpenSearch to include this functionality in another version.
    • Wait for the OpenSearch fork and include this functionality.

@alberpilot
Copy link
Contributor

Blocked due: #1886 (comment)

@rauldpm
Copy link
Member

rauldpm commented Nov 3, 2022

Update report

  • Working on the issue Black squared icon in Wazuh Dashboard #1907, a configuration has been found that can be applied in the opensearch_dashboards.yml file that allows direct access to the logo component so that it can be modified directly without the need to wait for OpenSearch to add such functionality in its branding customization.
opensearch_security.ui.basicauth.login.brandimage: "https://cdn-icons-png.flaticon.com/512/1/1601.png"
opensearch_security.ui.basicauth.login.title: "Custom image"

Screenshot_20221103_153008

  ui: {
    basicauth: {
      login: {
        title: string;
        subtitle: string;
        showbrandimage: boolean;
        brandimage: string;
        buttonstyle: string;
      };
    };
  • That said, after seeing this new configuration, and verifying that the construction of the package does not affect the change of the logos but that it is related to OpenSearch itself, no action is required on it.

@okynos okynos moved this from Triage to In Progress in Release 4.4.0 Nov 3, 2022
@okynos
Copy link
Contributor

okynos commented Nov 4, 2022

All seems to be clear. If anyone wants to change the logo could use these indications.

Regards.

@okynos okynos closed this as completed Nov 4, 2022
Repository owner moved this from In Progress to Done in Release 4.4.0 Nov 4, 2022
@vikman90 vikman90 added type/bug Bug issue and removed type: bug labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants