Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Python version and urllib3 to 1.26.20 #7978

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Change the Python version and urllib3 to 1.26.20 #7978

merged 2 commits into from
Nov 22, 2024

Conversation

javiersanchz
Copy link
Member

This PR closes wazuh/wazuh#26695, by modifying the Python version to 3.8 and changing the urllib3 dependency version to 1.26.20

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@javiersanchz javiersanchz self-assigned this Nov 20, 2024
@javiersanchz javiersanchz linked an issue Nov 20, 2024 that may be closed by this pull request
ERROR: Could not find a version that satisfies the requirement docker==7.1.0 wazuh/wazuh#26695
Closed
nico-stefani
nico-stefani previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fdalmaup
fdalmaup requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, nevertheless we should show proof that the DockerListener is working as expected in Amazon Linux 2

fdalmaup
fdalmaup previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javimed javimed added level/task Task issue type/bug Bug issue labels Nov 21, 2024
javimed
javimed previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What about lines #43, #48, and #55 in source/proof-of-concept-guide/monitoring-docker.rst?

@javiersanchz javiersanchz dismissed stale reviews from javimed, fdalmaup, and nico-stefani via 023ad94 November 22, 2024 09:09
@javiersanchz javiersanchz mentioned this pull request Nov 22, 2024
Closed
@javimed javimed merged commit 2046bcf into 4.10.0 Nov 22, 2024
3 checks passed
@javimed javimed deleted the bug/26695-change-urllib3-version branch November 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javimed javimed javimed approved these changes

@fdalmaup fdalmaup fdalmaup left review comments

@nico-stefani nico-stefani nico-stefani left review comments

Assignees

@javiersanchz javiersanchz

Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Release 4.10.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: Could not find a version that satisfies the requirement docker==7.1.0
4 participants
@javiersanchz @nico-stefani @fdalmaup @javimed