Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Python 3.12 #7673

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

nico-stefani
Copy link
Member

@nico-stefani nico-stefani commented Aug 15, 2024

Description

This PR closes wazuh/wazuh#25075. Add support to run the AWS wodle with Python 3.12

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@nico-stefani nico-stefani force-pushed the enhancement/25075-add-compat-for-python312 branch from 02ea40b to 3d9ba90 Compare August 15, 2024 20:00
@nico-stefani nico-stefani changed the title Add support for Python 3.12 Add compatibility with Python 3.12 Aug 15, 2024
@nico-stefani nico-stefani force-pushed the enhancement/25075-add-compat-for-python312 branch from 3d9ba90 to e5d7688 Compare August 20, 2024 19:29
@javiersanchz javiersanchz self-requested a review August 21, 2024 06:55
javiersanchz
javiersanchz previously approved these changes Aug 21, 2024
Copy link
Member

@javiersanchz javiersanchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

  • The changes added to the documentation are correct.

  • AWS Cloudwatch is functioning properly after the change.

  • The rest of the tests with integrations are correct in the different versions of Python.

From my side, LGTM!

@nico-stefani nico-stefani force-pushed the enhancement/25075-add-compat-for-python312 branch from e5d7688 to 475fe37 Compare August 26, 2024 11:29
@nico-stefani nico-stefani requested a review from fdalmaup August 26, 2024 11:30
fdalmaup
fdalmaup previously approved these changes Aug 26, 2024
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels Aug 26, 2024
@javimed javimed merged commit 15a377a into 4.9.1 Aug 27, 2024
2 checks passed
@javimed javimed deleted the enhancement/25075-add-compat-for-python312 branch August 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incompatibility of boto3 with Python 3.12 on Fedora 40
4 participants