Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PDF custom branding logo property #7646

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Aug 8, 2024

Description

In User manual > Wazuh dashboard > Setting up custom branding customization.reports.logo is incorrectly named. It was changed to customization.logo.reports

Evidences

image
image

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@JuanGarriuz JuanGarriuz self-assigned this Aug 8, 2024
@JuanGarriuz JuanGarriuz changed the base branch from master to 4.9.0 August 8, 2024 08:13
@JuanGarriuz JuanGarriuz marked this pull request as ready for review August 8, 2024 08:16
@JuanGarriuz JuanGarriuz changed the title Bug/7640 fix pdf custom branding logo reference Fixed pdf custom branding logo property Aug 8, 2024
@JuanGarriuz JuanGarriuz changed the title Fixed pdf custom branding logo property Fixed PDF custom branding logo property Aug 8, 2024
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao Desvelao requested a review from javimed August 8, 2024 08:24
@javimed javimed added level/task Task issue type/bug Bug issue labels Aug 8, 2024
@javimed javimed merged commit 04b6e22 into 4.9.0 Aug 8, 2024
3 checks passed
@javimed javimed deleted the bug/7640-fix-pdf-custom-branding-logo-reference branch August 8, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
4 participants