Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to disable the edition of configuration through API endpoints and UI #7220

Merged
merged 3 commits into from
May 9, 2024
Merged

Add ability to disable the edition of configuration through API endpoints and UI #7220

merged 3 commits into from
May 9, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Apr 19, 2024 •
edited by javimed
Loading

This pull requests add a plugin setting to the configuration file to manage the ability to configure the the configuraiton from API endpoints and UI.

  • Add configuration.ui_api_editable setting to the configuration file specification

Description

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@Desvelao
feat(wazuh-dashboard): add setting to manage the ability to configure…
65d2ecf 
… the settings from API endpoints and UI

- Add configuration.ui_api_editable setting to the configuration file specification
@Desvelao Desvelao self-assigned this Apr 19, 2024
@Desvelao Desvelao mentioned this pull request Apr 19, 2024
Closed
6 tasks
@Desvelao Desvelao linked an issue May 3, 2024 that may be closed by this pull request
Disable settings with wazuh.yml configuration wazuh/wazuh-dashboard-plugins#6557
Closed
6 tasks
@Desvelao Desvelao marked this pull request as ready for review May 3, 2024 07:37
asteriscos
asteriscos previously approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

image

image

@Desvelao Desvelao requested a review from javimed May 6, 2024 08:53
@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels May 6, 2024
@Desvelao @javimed
fix: apply request changes
987ec7b 
Co-authored-by: Javier Medeot <[email protected]>
@Desvelao Desvelao requested review from javimed and asteriscos May 8, 2024 06:12
Tostti
Tostti approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javimed javimed merged commit f40365e into 4.9.0 May 9, 2024
3 checks passed
@javimed javimed deleted the feat/wdp-6557-disable-ability-edit-configuration branch May 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javimed javimed javimed approved these changes

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable settings with wazuh.yml configuration
4 participants
@Desvelao @asteriscos @Tostti @javimed