Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation after package migration #7204

Merged
merged 13 commits into from
May 31, 2024
Merged

Update documentation after package migration #7204

merged 13 commits into from
May 31, 2024

Conversation

lchico
Copy link
Member

@lchico lchico commented Apr 16, 2024 •
edited by javimed
Loading

Description

Related issue
#7184

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@lchico lchico changed the base branch from master to 4.9.0 April 16, 2024 21:46
@lchico lchico linked an issue Apr 16, 2024 that may be closed by this pull request
Update documentation after package migration #7184
Closed
5 tasks
@lchico lchico force-pushed the enhancement/7184-update-documentation-after-package-migration branch from 6f61804 to a503f27 Compare April 17, 2024 13:56
@MarcelKemp MarcelKemp changed the title Enhancement/7184 update documentation after package migration Update documentation after package migration May 13, 2024
@mjcr99 mjcr99 marked this pull request as ready for review May 16, 2024 11:23
@mjcr99 mjcr99 force-pushed the enhancement/7184-update-documentation-after-package-migration branch from e635384 to b532888 Compare May 16, 2024 15:42
MarcelKemp
MarcelKemp requested changes May 21, 2024
View reviewed changes
Copy link
Member

@MarcelKemp MarcelKemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, just a few minor changes.

source/development/packaging/generate-deb-rpm-package.rst Outdated Show resolved Hide resolved
source/development/packaging/generate-osx-package.rst Outdated Show resolved Hide resolved
@mjcr99 mjcr99 force-pushed the enhancement/7184-update-documentation-after-package-migration branch from 5134e7c to 3c3c3c0 Compare May 21, 2024 11:53
MarcelKemp
MarcelKemp previously approved these changes May 21, 2024
View reviewed changes
MarcelKemp
MarcelKemp previously approved these changes May 21, 2024
View reviewed changes
@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels May 21, 2024
@lchico
Copy link
Member Author

lchico commented May 31, 2024

@javimed, thanks for your comments, they were addressed. PTAL

@lchico lchico force-pushed the enhancement/7184-update-documentation-after-package-migration branch from 7b3029b to 01b1fe2 Compare May 31, 2024 17:48
@javimed javimed merged commit f7099c8 into 4.9.0 May 31, 2024
3 checks passed
@javimed javimed deleted the enhancement/7184-update-documentation-after-package-migration branch May 31, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcr99 mjcr99 mjcr99 left review comments

@javimed javimed javimed requested changes

@MarcelKemp MarcelKemp MarcelKemp left review comments

Assignees
No one assigned
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation after package migration
6 participants
@lchico @MarcelKemp @javimed @mjcr99 @jr0me @jotacarma90