Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove launchtl unload step from macOS uninstalling manual #7123

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

nmkoremblum
Copy link
Contributor

@nmkoremblum nmkoremblum commented Mar 14, 2024

Close the issue
#7109

Description

The macOS uninstalling manual page was modified given the launchtl unload command might throw an error if the service has not yet been loaded.

In this case, we choose to delete such a step. Given this, after removing the Wazuh agent, if the service is loaded, it will continue to be listed until the system is restarted or the service is manually unloaded.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@nmkoremblum nmkoremblum added Documentation improvements Documentation improvements macOS type/enhancement Enhancement issue labels Mar 14, 2024
@nmkoremblum nmkoremblum requested a review from javimed March 14, 2024 15:38
@nmkoremblum nmkoremblum self-assigned this Mar 14, 2024
@nmkoremblum nmkoremblum requested a review from cborla March 14, 2024 15:38
@nmkoremblum nmkoremblum linked an issue Mar 14, 2024 that may be closed by this pull request
cborla
cborla previously approved these changes Mar 14, 2024
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cborla cborla changed the base branch from master to 4.8.0 March 14, 2024 16:09
@cborla cborla dismissed their stale review March 14, 2024 16:09

The base branch was changed.

@cborla cborla changed the base branch from 4.8.0 to master March 14, 2024 16:10
@javimed javimed added level/task Task issue type/bug Bug issue and removed type/enhancement Enhancement issue labels Mar 15, 2024
@nbertoldo nbertoldo force-pushed the 7109-remove-launchctl-unload-macos-uninstall branch from 332ab03 to 4f03394 Compare March 15, 2024 13:17
@nbertoldo nbertoldo changed the base branch from master to 4.8.0 March 15, 2024 13:18
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm, unless we want it live in production now as a 4.7 hotfix which is perfectly valid for the case of our documentation. This would require changng base branch to 4.7.

@cborla
Copy link
Member

cborla commented Mar 15, 2024

@javimed this change applies for version 4.8.0 onwards, that's why the base change we made later, this is the PR where the change is included only in 4.8.0.

@javimed javimed merged commit 6077b84 into 4.8.0 Mar 15, 2024
3 checks passed
@javimed javimed deleted the 7109-remove-launchctl-unload-macos-uninstall branch March 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation improvements Documentation improvements level/task Task issue macOS type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

macOS Wazuh agent uninstall step fails
3 participants