Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app / component to add sample data #56

Merged
merged 7 commits into from
May 5, 2023
Merged

Remove app / component to add sample data #56

merged 7 commits into from
May 5, 2023

Conversation

yenienserrano
Copy link
Member

Description

  • Removed all the buttons that redirect to the OpenSearch sample data.
  • Removed the routes to this app / component.
  • Accommodated tests & test snapshots.

Issues Resolved

Screenshots

image
image
image
image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Apr 28, 2023 that may be closed by this pull request
Disable the addition of sample data #19
Closed
3 tasks
This was referenced Apr 28, 2023
Closed
Closed
@chantal-kelm chantal-kelm self-requested a review April 28, 2023 17:16
chantal-kelm
chantal-kelm approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Captura de pantalla 2023-04-28 a la(s) 14 16 41

Captura de pantalla 2023-04-28 a la(s) 14 14 14

Captura de pantalla 2023-04-28 a la(s) 14 12 42

Machi3mfl
Machi3mfl approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

@AlexRuiz7 AlexRuiz7 force-pushed the 19-remove-sample-data branch from 228ffd9 to 3a923e2 Compare May 4, 2023 11:25
@AlexRuiz7 AlexRuiz7 merged commit 1a84d6b into wz-init May 5, 2023
@AlexRuiz7 AlexRuiz7 deleted the 19-remove-sample-data branch May 10, 2023 14:09
yenienserrano added a commit that referenced this pull request Jun 1, 2023
@yenienserrano
Remove app / component to add sample data (#56)
0559493 
Signed-off-by: yenienserrano <[email protected]>
yenienserrano added a commit that referenced this pull request Jun 1, 2023
@yenienserrano
Remove app / component to add sample data (#56)
1c80451 
Signed-off-by: yenienserrano <[email protected]>
yenienserrano added a commit that referenced this pull request Jun 2, 2023
@yenienserrano
Remove app / component to add sample data (#56)
07f4c5d 
Signed-off-by: yenienserrano <[email protected]>
yenienserrano added a commit that referenced this pull request Jun 9, 2023
@yenienserrano
Remove app / component to add sample data (#56)
27e01b6 
Signed-off-by: yenienserrano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable the addition of sample data
4 participants
@yenienserrano @Machi3mfl @chantal-kelm @AlexRuiz7