Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the overview app #54

Merged
merged 6 commits into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
# have added an script to automatically detect the chrome version and
# installed the correct chromedriver accordingly.
- name: Setup chromedriver
run: yarn add --dev chromedriver@109.0.0
run: yarn add --dev chromedriver@112.0.0

- name: Run bootstrap
run: yarn osd bootstrap
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/opensearch_dashboards_overview/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@

export const PLUGIN_ID = 'opensearchDashboardsOverview';
export const PLUGIN_NAME = 'Overview';
export const PLUGIN_PATH = `/app/opensearch_dashboards_overview`;
export const PLUGIN_PATH = `/app/home/`;
export const PLUGIN_ICON = 'inputOutput';

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions src/plugins/opensearch_dashboards_overview/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ export class OpenSearchDashboardsOverviewPlugin
return hasOpenSearchDashboardsApp;
}),
distinct(),
map((hasOpenSearchDashboardsApp) => {
map(() => {
return () => {
if (!hasOpenSearchDashboardsApp) {
return { status: AppStatus.inaccessible, navLinkStatus: AppNavLinkStatus.hidden };
} else {
return { status: AppStatus.accessible, navLinkStatus: AppNavLinkStatus.default };
}
// Wazuh: Hide the OpenSearch Dashboards Overview app
return {
status: AppStatus.inaccessible,
navLinkStatus: AppNavLinkStatus.hidden,
};
};
})
);
Expand Down
5 changes: 4 additions & 1 deletion test/functional/apps/visualize/_custom_branding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const expectedWelcomeMessage = 'Welcome to OpenSearch';

describe('OpenSearch Dashboards branding configuration', function customHomeBranding() {
describe('should render overview page', async () => {
/**
* This test is skipped because the overview page is not available.
*/
describe.skip('should render overview page', async () => {
this.tags('includeFirefox');

before(async function () {
Expand Down