Terminal freezes on deb upgrade #316

Tostti · 2024-09-18T19:08:25Z

Description

This PR fixes a problem that caused upgrades in deb environments to freeze the terminal until the user presses enter. The problem was also in rpm packages, but it didn't cause any terminal issues.

Issues Resolved

#301

Test

RPM

Install a previous wazuh version

yum install libcap
rpm --import https://packages.wazuh.com/key/GPG-KEY-WAZUH
echo -e '[wazuh]\ngpgcheck=1\ngpgkey=https://packages.wazuh.com/key/GPG-KEY-WAZUH\nenabled=1\nname=EL-$releasever - Wazuh\nbaseurl=https://packages.wazuh.com/4.x/yum/\nprotect=1' | tee /etc/yum.repos.d/wazuh.repo
yum -y install wazuh-dashboard

Install the new package on top of it. Verify that the installation ends successfully, the terminal doesn't freeze and no errors are shown.

yum localinstall <package>

DEB

Install a previous wazuh version

apt-get update
apt-get install debhelper tar curl libcap2-bin #debhelper version 9 or later
apt-get install gnupg apt-transport-https
curl -s https://packages.wazuh.com/key/GPG-KEY-WAZUH | gpg --no-default-keyring --keyring gnupg-ring:/usr/share/keyrings/wazuh.gpg --import && chmod 644 /usr/share/keyrings/wazuh.gpg
echo "deb [signed-by=/usr/share/keyrings/wazuh.gpg] https://packages.wazuh.com/4.x/apt/ stable main" | tee -a /etc/apt/sources.list.d/wazuh.list
apt-get update
apt-get -y install wazuh-dashboard

Install the new package on top of it. Verify that the installation ends successfully, the terminal doesn't freeze and no errors are shown.

dpkg -i <package>

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

asteriscos · 2024-09-19T09:34:03Z

Test Deb 🟢

The upgrade to 4.9.1 from 4.8.2 didn't freeze the terminal.

root@ubuntu-jammy:/etc/wazuh-dashboard# dpkg -i /vagrant/packages/wazuh-dashboard_4.9.1-1_amd64_1f08cd29c4.deb 
(Reading database ... 178533 files and directories currently installed.)
Preparing to unpack .../wazuh-dashboard_4.9.1-1_amd64_1f08cd29c4.deb ...
Unpacking wazuh-dashboard (4.9.1-1) over (4.8.2-1) ...
Setting up wazuh-dashboard (4.9.1-1) ...
Installing new version of config file /etc/systemd/system/wazuh-dashboard ...
Installing new version of config file /etc/wazuh-dashboard/node.options ...

Configuration file '/etc/wazuh-dashboard/opensearch_dashboards.yml'
 ==> Modified (by you or by a script) since installation.
 ==> Package distributor has shipped an updated version.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** opensearch_dashboards.yml (Y/I/N/O/D/Z) [default=N] ?

Check keystore

root@ubuntu-jammy:/home/vagrant# ls -la /etc/wazuh-dashboard/
certs/                               opensearch_dashboards.keystore       opensearch_dashboards.yml.dpkg-dist
node.options                         opensearch_dashboards.yml

Test RPM 🟢

The upgrade to 4.9.1 from 4.8.2 didn't freeze the terminal.

[root@localhost vagrant]# yum localinstall /vagrant/packages/wazuh-dashboard_4.9.1-1_x86_64_398a9479ed.rpm 
Failed to set locale, defaulting to C.UTF-8
CentOS Linux 8 - AppStream                                                                             21 kB/s | 4.3 kB     00:00    
CentOS Linux 8 - BaseOS                                                                                58 kB/s | 3.9 kB     00:00    
CentOS Linux 8 - Extras                                                                                23 kB/s | 1.5 kB     00:00    
Dependencies resolved.
======================================================================================================================================
 Package                             Architecture               Version                        Repository                        Size
======================================================================================================================================
Upgrading:
 wazuh-dashboard                     x86_64                     4.9.1-1                        @commandline                     253 M

Transaction Summary
======================================================================================================================================
Upgrade  1 Package

Total size: 253 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                              1/1 
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                                                               1/1 
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                                                               1/2 
  Upgrading        : wazuh-dashboard-4.9.1-1.x86_64                                                                               1/2 
warning: /etc/wazuh-dashboard/opensearch_dashboards.yml created as /etc/wazuh-dashboard/opensearch_dashboards.yml.rpmnew

  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                                                               1/2 
  Running scriptlet: wazuh-dashboard-4.8.2-1.x86_64                                                                               2/2 
  Cleanup          : wazuh-dashboard-4.8.2-1.x86_64                                                                               2/2 
  Running scriptlet: wazuh-dashboard-4.8.2-1.x86_64                                                                               2/2 
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                                                               2/2 
  Running scriptlet: wazuh-dashboard-4.8.2-1.x86_64                                                                               2/2 
  Verifying        : wazuh-dashboard-4.9.1-1.x86_64                                                                               1/2 
  Verifying        : wazuh-dashboard-4.8.2-1.x86_64                                                                               2/2 

Upgraded:
  wazuh-dashboard-4.9.1-1.x86_64                                                                                                      

Complete!

Check keystore

[root@localhost vagrant]# ls -la /etc/wazuh-dashboard/
certs/                            opensearch_dashboards.keystore    opensearch_dashboards.yml.rpmnew
node.options                      opensearch_dashboards.yml

JuanGarriuz · 2024-09-19T10:57:19Z

Test

RPM🟢

[root@fedora37 vagrant]# yum install /vagrant/wazuh-dashboard_4.9.1-1_x86_64_398a9479ed.rpm
Last metadata expiration check: 0:02:55 ago on Thu 19 Sep 2024 10:52:50 AM UTC.
Dependencies resolved.
======================================================================================================
 Package                     Architecture       Version                Repository                Size
======================================================================================================
Upgrading:
 wazuh-dashboard             x86_64             4.9.1-1                @commandline             253 M

Transaction Summary
======================================================================================================
Upgrade  1 Package

Total size: 253 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                              1/1
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                               1/2
  Upgrading        : wazuh-dashboard-4.9.1-1.x86_64                                               1/2
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                               1/2
  Running scriptlet: wazuh-dashboard-4.9.0-2.x86_64                                               2/2
  Cleanup          : wazuh-dashboard-4.9.0-2.x86_64                                               2/2
  Running scriptlet: wazuh-dashboard-4.9.0-2.x86_64                                               2/2
  Running scriptlet: wazuh-dashboard-4.9.1-1.x86_64                                               2/2
  Running scriptlet: wazuh-dashboard-4.9.0-2.x86_64                                               2/2
  Verifying        : wazuh-dashboard-4.9.1-1.x86_64                                               1/2
  Verifying        : wazuh-dashboard-4.9.0-2.x86_64                                               2/2

Upgraded:
  wazuh-dashboard-4.9.1-1.x86_64

Complete!

DEB 🟢


root@ubuntu2204:/vagrant# dpkg -i wazuh-dashboard_4.9.1-1_amd64_1f08cd29c4.deb
(Reading database ... 178049 files and directories currently installed.)
Preparing to unpack wazuh-dashboard_4.9.1-1_amd64_1f08cd29c4.deb ...
Unpacking wazuh-dashboard (4.9.1-1) over (4.9.0-2) ...
Setting up wazuh-dashboard (4.9.1-1) ...
root@ubuntu2204:/vagrant#

JuanGarriuz

LGTM!!

…rch-project#6427) (opensearch-project#6628) * [Workspace] Jump to non-workspace url when clicking home icon (wazuh#316) * temp: save * feat: complete the feature * feat: remove useless code * fix: bootstrap error * fix: bootstrap error * fix: page not found error * fix: anchor href * feat: update toNavLink to comply with workspace * feat: change to workspaceless * feat: change to workspaceless * feat: change to workspaceless * feat: register list and create page as workspaceless * feat: optimize code * feat: update to WorkspaceVisibility * feat: add unit test * feat: optimize the jump logic * fix: unit test * feat: make app inaccessible if workspaceAccessibility is No --------- * refactor: using WorkspaceAvailability * feat: change test name * feat: update wording * feat: update test * feat: add unit test * feat: remove CHANGELOG change * Changeset file for PR opensearch-project#6427 created/updated * Apply suggestions from code review * Update src/plugins/workspace/public/utils.test.ts * Lint src/plugins/workspace/public/utils.test.ts * Lint src/plugins/workspace/public/utils.test.ts * Lint src/plugins/workspace/public/utils.test.ts * fix: lint error * fix: unit test --------- (cherry picked from commit 104ee42) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: Miki <[email protected]>

Tostti added 2 commits September 18, 2024 15:55

Fix deb package generation

20d0cd1

Fix RPM package generation

398a947

Tostti self-assigned this Sep 18, 2024

Tostti linked an issue Sep 18, 2024 that may be closed by this pull request

Wazuh dashboard installation freezes terminal #301

Closed

Update changelog

1f08cd2

asteriscos previously approved these changes Sep 19, 2024

View reviewed changes

Upgrade snapshots

935ccab

Tostti dismissed asteriscos’s stale review via 935ccab September 19, 2024 10:40

asteriscos approved these changes Sep 19, 2024

View reviewed changes

JuanGarriuz approved these changes Sep 19, 2024

View reviewed changes

asteriscos merged commit e5fd956 into 4.9.1 Sep 19, 2024
57 of 61 checks passed

asteriscos deleted the fix/301-terminal-freezes-on-upgrade branch September 19, 2024 11:58

Desvelao pushed a commit that referenced this pull request Sep 23, 2024

Terminal freezes on deb upgrade (#316)

a0c0721

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terminal freezes on deb upgrade #316

Terminal freezes on deb upgrade #316

Tostti commented Sep 18, 2024

asteriscos commented Sep 19, 2024 •

edited

Loading

JuanGarriuz commented Sep 19, 2024 •

edited

Loading

JuanGarriuz left a comment

Terminal freezes on deb upgrade #316

Terminal freezes on deb upgrade #316

Conversation

Tostti commented Sep 18, 2024

Description

Issues Resolved

Test

RPM

DEB

Check List

asteriscos commented Sep 19, 2024 • edited Loading

Test Deb 🟢

Test RPM 🟢

JuanGarriuz commented Sep 19, 2024 • edited Loading

Test

RPM🟢

DEB 🟢

JuanGarriuz left a comment

Choose a reason for hiding this comment

asteriscos commented Sep 19, 2024 •

edited

Loading

JuanGarriuz commented Sep 19, 2024 •

edited

Loading