forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify link to sample data in the section dashboards and references to opensearch dashboards #311
Merged
Desvelao
merged 6 commits into
4.9.1
from
bug/307-modify-link-to-sample-data-in-the-section-dashboards-and-references-to-opensearch-dashboards
Sep 17, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o opensearch dashboards
Desvelao
reviewed
Sep 16, 2024
src/plugins/dashboard/public/application/utils/get_no_items_message.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Sep 16, 2024
src/plugins/dashboard/public/application/utils/get_no_items_message.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Sep 17, 2024
JuanGarriuz
previously approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
JuanGarriuz
approved these changes
Sep 17, 2024
Desvelao
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Desvelao
deleted the
bug/307-modify-link-to-sample-data-in-the-section-dashboards-and-references-to-opensearch-dashboards
branch
September 17, 2024 08:25
Desvelao
pushed a commit
that referenced
this pull request
Sep 23, 2024
…o opensearch dashboards (#311) Co-authored-by: JuanGarriuz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify link to sample data in the section dashboards and references to Opensearch dashboards
Issues Resolved
#307
Evidence
Grabacion.de.pantalla.2024-09-13.a.la.s.3.20.54.p.m.mov
Test
In order to test this PR you must:
From the
wazuh-dashboard
environment:Add this configuration to the
wazuh.yml
file:checks.template: false
You must also mount as volume the plugins inside your
wazuh-dashboard
container in thedev.yml
file:From
wazuh-dashboard-plugins
environments raise a rel.sh environment:Set up a
rel
environmentComment out the
wazuh-dashboard
containerMap the port in the container
wazuh-manager
:Go to the side menu click on the Dashboards tab and verify:
Verify that the link with the message “Install some sample data” redirects to sample data
Verify that where it used to say Opensearch dashboards it now says Wazuh dashboards
Check List
yarn test:jest
yarn test:jest_integration