Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix css selector to login button #181

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix css selector to login button #181

merged 1 commit into from
May 22, 2024

Conversation

lucianogorza
Copy link

@lucianogorza lucianogorza commented May 17, 2024 •
edited
Loading

Description

This PR improves the CSS selector for the login button to apply Wazuh branding colors. Previously, the CSS selector was less specific, so the style was incorrectly applied to other buttons like App Settings > Miscellaneous.

Issues Resolved

Evidence

Login

image

Miscellaneous button

image

Test

  1. Generate the packages and install Wazuh components.
  2. Go to Login and check the button color. The button must have the color of the brand.
  3. Go to App Settings > Miscellaneous and check the button color. The button must have the color of the theme.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

This was referenced May 17, 2024
Closed
Closed
@lucianogorza lucianogorza self-assigned this May 17, 2024
@lucianogorza lucianogorza marked this pull request as ready for review May 17, 2024 19:35
@gdiazlo gdiazlo linked an issue May 20, 2024 that may be closed by this pull request
Fix wrong color of button on App Settings > Miscellaneous wazuh/wazuh-dashboard-plugins#6571
Closed
2 tasks
@chantal-kelm chantal-kelm self-requested a review May 22, 2024 11:43
chantal-kelm
chantal-kelm approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2024-05-22 a la(s) 8 42 59 a  m Captura de pantalla 2024-05-22 a la(s) 9 00 43 a  m

@yenienserrano yenienserrano self-requested a review May 22, 2024 13:07
yenienserrano
yenienserrano approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image image

@asteriscos asteriscos merged commit fb728f9 into 4.9.0 May 22, 2024
69 of 70 checks passed
@asteriscos asteriscos deleted the fix/6571-fix-wrong-color-of-button-on-app-settings-miscellaneous branch May 22, 2024 13:56
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
@lucianogorza @yenienserrano
Fix css selector to login button (#181)
5af2af1
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
@lucianogorza @yenienserrano
Fix css selector to login button (#181)
fbc3431
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
@lucianogorza @yenienserrano
Fix css selector to login button (#181)
b98089e
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
@lucianogorza @yenienserrano
Fix css selector to login button (#181)
a38c8c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@lucianogorza lucianogorza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wrong color of button on App Settings > Miscellaneous
4 participants
@lucianogorza @yenienserrano @chantal-kelm @asteriscos