Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret for aws region #171

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add secret for aws region #171

merged 1 commit into from
Apr 24, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 22, 2024

Description

This PR modifies the package building workflow to take the AWS region from the secrets.

Issues Resolved

#170

Evidence

Screenshot 2024-04-22 at 15 09 57

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Apr 22, 2024
@Tostti Tostti linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit d3c021d into 4.9.0 Apr 24, 2024
74 checks passed
@Tostti Tostti deleted the 170-add-secret-aws-region branch April 24, 2024 10:32
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh packages redesign tier 1 - Use secret for AWS region
2 participants