Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent help menu #139

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Fix inconsistent help menu #139

merged 9 commits into from
Jan 31, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Jan 30, 2024

Description

This PR modifies the help menu, to be updated to the current requirements, and to avoid the inconsistency and duplication that occured previously

Issues Resolved

wazuh/wazuh-dashboard-plugins#6368

Evidence

image
image

Test

Verify that the help menu has the correct icons and links.

Note: it is possible to run yarn opensearch snapshot in the repo before running yarn start, this will bring up an Opensearch instance that works with the dev environments.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti mentioned this pull request Jan 30, 2024
8 tasks
@Tostti Tostti linked an issue Jan 30, 2024 that may be closed by this pull request
3 tasks
@Tostti Tostti marked this pull request as ready for review January 30, 2024 11:31
@Tostti Tostti self-assigned this Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (942ecfb) 66.82% compared to head (d228439) 66.82%.

Files Patch % Lines
.../core/public/chrome/ui/header/header_help_menu.tsx 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           2.11.1     #139   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files        3284     3284           
  Lines       63180    63184    +4     
  Branches    10051    10052    +1     
=======================================
+ Hits        42221    42225    +4     
+ Misses      18481    18480    -1     
- Partials     2478     2479    +1     
Flag Coverage Δ
Linux_1 35.26% <60.00%> (+<0.01%) ⬆️
Linux_2 55.23% <80.00%> (+<0.01%) ⬆️
Linux_3 43.85% <60.00%> (+0.01%) ⬆️
Linux_4 35.47% <60.00%> (+<0.01%) ⬆️
Windows_1 35.27% <60.00%> (+<0.01%) ⬆️
Windows_2 55.20% <80.00%> (+<0.01%) ⬆️
Windows_3 43.85% <60.00%> (+<0.01%) ⬆️
Windows_4 35.47% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image
image

@Tostti Tostti merged commit 345b5ce into 2.11.1 Jan 31, 2024
108 checks passed
@Tostti Tostti deleted the 6368-fix-inconsistent-help-menu branch January 31, 2024 19:22
yenienserrano pushed a commit that referenced this pull request Feb 21, 2024
Tostti added a commit that referenced this pull request Apr 5, 2024
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated links from help menu
4 participants