Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve agent details page #7196

Merged
merged 38 commits into from
Dec 11, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Dec 5, 2024

Description

We want to refine some aspects of the Agent dashboard to enhance the use experience. To achieve this we will do the following tasks.

Issues Resolved

Closes #7193

Evidence

  • Adjusted the height of the event count evolution visualization.

    image

  • Standardized padding for the "Top 5 Packages" table to align with other tables.

    image

    image

  • Reduced the width of small fields in the Agent Info ribbon for a more compact layout.

    image

    image

  • Replaced "Malware Detection" with "Vulnerability Detection" in the agent's pinned navigation menu.

    image

  • Aligned "Vulnerability Detection" KPIs to the left.

    image

  • Max quantity of groups is 3

    image

Test

  1. Navigate to Agents management » Summary
  2. Select any agent.
  3. Review the checklist located in the Evidence section.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…oved layout consistency and visual appearance
…etection for better alignment with application terminology
…or displaying condensed items in the ribbon component
@guidomodarelli guidomodarelli linked an issue Dec 5, 2024 that may be closed by this pull request
5 tasks
…proved layout consistency in dashboard panels
@guidomodarelli guidomodarelli changed the title Improve-agent-details-page Improve agent details page Dec 5, 2024
Tostti

This comment was marked as resolved.

@gdiazlo

This comment was marked as resolved.

Tostti
Tostti previously approved these changes Dec 10, 2024
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue reported in #7196 (review).

Test 🟢

imagen

CR 🟢

LGTM

@chantal-kelm chantal-kelm self-requested a review December 10, 2024 15:55
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Reduced the width of small fields in the Agent Info ribbon for a more compact layout.

Captura de pantalla 2024-12-10 a la(s) 3 21 56 p  m

🔴 Replaced "Malware Detection" with "Vulnerability Detection" in the agent's pinned navigation menu.

Captura de pantalla 2024-12-10 a la(s) 3 17 19 p  m

…mproved readability in WzTextWithTooltipIfTruncated component
…e and improved readability in WzTextWithTooltipIfTruncated component
…ved agent OS representation in the application
… name in InventoryMetrics and AgentInfo components
…tentStyle for cleaner code in ribbon-item component
…roved clarity in ribbon-item component rendering
… with hooks for cleaner state management and rendering logic
chantal-kelm
chantal-kelm previously approved these changes Dec 11, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-12-11 a la(s) 2 49 55 p  m

…p-alive fields for better layout consistency
asteriscos
asteriscos previously approved these changes Dec 11, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Firefox

image

Chrome

image

asteriscos
asteriscos previously approved these changes Dec 11, 2024
chantal-kelm
chantal-kelm previously approved these changes Dec 11, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2024-12-11 a la(s) 3 09 37 p  m

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.74% ( 4385 / 29734 )
Branches 9.71% ( 1872 / 19266 )
Functions 14.5% ( 1041 / 7179 )
Lines 14.95% ( 4277 / 28607 )

@asteriscos asteriscos merged commit 6a0d63e into 4.10.1 Dec 11, 2024
5 of 6 checks passed
@asteriscos asteriscos deleted the enhancement/7193-improve-agent-details-page branch December 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve agent details page
6 participants