Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzip command not found in package generation action #7180

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Nov 27, 2024

Description

This pull request adds the unzip package to the test plugins post workflow to fix the unzip: command not found error. It also adds support for dev branches that contain / in their name.

Issues Resolved

Evidence

https://github.com/wazuh/wazuh-dashboard-plugins/actions/runs/12055324147/job/33615734496

Test

  • Run the wazuh dashboard package build action and verify there's no error in the output.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.89% ( 4436 / 29774 )
Branches 9.76% ( 1876 / 19206 )
Functions 14.66% ( 1056 / 7200 )
Lines 15.11% ( 4330 / 28646 )

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asteriscos asteriscos merged commit 23b69cd into 4.10.0 Nov 28, 2024
9 checks passed
@asteriscos asteriscos deleted the bug/430-unzip-command-not-found-in-package-generation-action branch November 28, 2024 11:10
Desvelao pushed a commit that referenced this pull request Dec 16, 2024
* Add install unzip command

* Fix unzip command

* Escalate root user privileges

* Fix unzip command path

* Unzip in dockefile

* Change for loop

* Change for loop

* add ls -la

* Change test plugins path

* change ls

* change folder name

* Comment the unzip process

* Clean code

* Format artifact name with slash

* Implement githubReference

* Test set -e

* Remove set -e test
Tostti pushed a commit that referenced this pull request Dec 16, 2024
* Update the actions' version (#7142)

* feat: integrate ButtonExploreAgent component into MainModuleAgent for enhanced agent interaction and updated layout consistency

* feat: add pinned agent mechanic across all pages for improved consistency in functionality and user experience

* feat: enhance ButtonPinnedAgent with clsx for dynamic class management and improved background styling

* refactor: clean up agent selector styles by removing unnecessary focus and hover states for better maintainability

* refactor: update WzButtonProps type to include EUI component properties for better flexibility and maintainability

* refactor: improve ButtonPinnedAgent structure by adding data-test attribute and simplifying JSX for cleaner code readability

* test: add tests for explore agent button rendering in various agent tabs for improved coverage and verification of UI functionality

* test: add tests for explore agent button rendering in various agent tabs for improved coverage and verification of UI functionality

refactor: enhance MainModuleAgent layout by adding margin and padding styles to EuiFlexItems for improved UI consistency

* refactor: add newline in ButtonPinnedAgent for improved readability and code consistency in explore agent button component

* chore: update CHANGELOG to clarify pinned agent mechanic in inventory, stats, and configuration for consistency across pages

* refactor: add unPinAgent functionality to agent components for enhanced user interaction and UI consistency across agent views

* refactor: remove unused EuiButtonEmpty import for cleaner code in configuration overview component

* refactor: update useGenericRequest hook for improved type safety and cleaner data handling in API requests

* refactor: enhance type safety in InventoryMetrics and streamline API request handling with updated useGenericRequest usage

* refactor: rename ErrorOrchestratorService to ErrorService for improved clarity and type safety in error handling logic

* refactor: add JSDoc comments to GenericRequest for improved type safety and better documentation of request parameters

* refactor: improve cluster handling logic and error management in WzConfigurationSwitch for better state management and readability

* refactor: streamline AgentStats component with improved type safety and error handling for enhanced clarity and maintainability

* Fix Prettier issue

* refactor: update test descriptions in MainModuleAgent tests to clarify the "Pinned Agent" button functionality across tabs

* refactor: remove deprecated Route for syscollector in AgentView to clean up component structure and improve readability

* refactor: rename PartialRecordMock to DeepPartialRecordMock for better clarity and maintainability in type definitions

* feat: add mock agent data for Debian, Windows, and Darwin to enhance testing and provide a comprehensive environment setup

* refactor: replace inline AGENT mock with import from test mocks for improved test organization and maintainability

* test: add API call verification in AgentStats tests to ensure correct fetching of agent stats during component rendering

* test: enhance AgentStats tests to verify API calls with correct agent IDs and endpoints on component updates

* test: refine AgentStats test description to clarify API call behavior when switching agents

* test: improve AgentStats tests to ensure correct column structure, titles, and CSV filename updates on rendering changes

* refactor: update breadcrumb types in useGlobalBreadcrumb for improved type safety and readability in context management

* refactor: enhance withGlobalBreadcrumb HOC for better type handling and maintainability in breadcrumb logic

* refactor: replace hardcoded path in agent stats breadcrumb with SECTIONS constant for improved maintainability and readability

* refactor: replace hardcoded agents-preview path with SECTIONS constant for improved maintainability and readability in configuration-main.js

* refactor: improve agent handling in withGlobalBreadcrumb for better maintainability and readability in configuration-main.js

* refactor: add global breadcrumb support in AgentView for better navigation and maintainability in index.tsx

* refactor: update unPinAgent to navigate with new URL structure for improved navigation in index.tsx

* refactor: add withGlobalBreadcrumb HOC to enhance navigation structure in agent index.tsx

* refactor: enhance AgentStats tests with clearer descriptions for column structure and title checks amidst agent changes

* refactor: replace jQuery with native DOM method for setting title attribute in breadcrumb configuration component

* refactor: improve syscollector metrics tests by adding agent ID handling and verifying data fetching for different agents

* refactor: add unit test for SoftwareTab rendering WindowsUpdatesTable on Windows platform in syscollector agent component

* refactor: add unit test for WindowsUpdatesTable to verify correct hotfixes endpoint when changing agents in syscollector component

* refactor: fix endpoint string in WindowsUpdatesTable test for accurate hotfixes URL when changing agents in syscollector component

* refactor: enhance WindowsUpdatesTable test to validate API requests for different agent IDs in syscollector component

* refactor: handle potential undefined values in packages-table component for safer access to sorting fields when rendering table

* test: add test suite for PackagesTable to validate API requests and table rendering for different agent IDs in syscollector component

* refactor: safeguard against undefined values for sorting fields in multiple syscollector table components during rendering

* test: add test suite for NetworkInterfacesTable to verify API requests and rendering behavior for changing agent IDs

* test: update test descriptions in PackagesTable and WindowsUpdatesTable for clarity on data being fetched for given agent IDs

* test: add tests for NetworkPortsTable to verify correct API requests and rendering behavior for different agent IDs

* test: rename test suite to NetworkPortsTable for clarity and proper context in related API request tests

* test: add NetworkSettingsTable tests to ensure correct rendering and API requests for changing agent IDs

* test: add tests for ProcessesTable to validate rendering and API requests when switching between agent IDs

* fix: improve optional chaining to direct access for initial sorting fields in network tables for better readability

* test: introduce reusable functions for validating agent API requests and endpoint rendering in various system collector tables

* ci: update GitHub Actions workflows to use actions/upload-artifact@v4 and clean up formatting across YAML files

* ci: upgrade actions/checkout to v4 across multiple workflows for consistency and improved features

* ci: upgrade Node.js setup to actions/setup-node@v4 in eslint and prettier workflows for enhanced performance and consistency

* ci: update manual-build workflow to use actions/download-artifact@v4 for improved functionality and consistency with other workflows

* ci: upgrade actions/dependency-review-action to v4 for enhanced functionality and consistency in dependency review process

* ci: add overwrite option in Cypress report workflows for improved file handling and consistency across all test configurations

* ci: standardize YAML formatting in workflows for better readability and consistency across all templates and steps

---------

Co-authored-by: Federico Rodriguez <[email protected]>

* Unzip command not found in package generation action (#7180)

* Add install unzip command

* Fix unzip command

* Escalate root user privileges

* Fix unzip command path

* Unzip in dockefile

* Change for loop

* Change for loop

* add ls -la

* Change test plugins path

* change ls

* change folder name

* Comment the unzip process

* Clean code

* Format artifact name with slash

* Implement githubReference

* Test set -e

* Remove set -e test

* Update .github/workflows/dev-environment.yml

* Fix actions artifact plugins name (#7174)

* Fix actions artifact plugins name

* Add plugins packages to plugins folder

* Unzip package zips

* feat: add engine and fleet to manual build GHA

* fix: revert number definition

* fix: revert usage of node: built-in modules

* fix: GHA build

---------

Co-authored-by: Guido Modarelli <[email protected]>
Co-authored-by: Federico Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unzip command not found messages in the package generation actions
2 participants